add `CStr::display` #139994

tamird · 2025-04-17T23:49:25Z

The implementation delegates to <ByteStr as Display>::fmt.

Link: rust-lang/libs-team#550
Link: #139984.

r? @BurntSushi
cc @Darksonn @tgross35 @ojeda @joshtriplett

tgross35 · 2025-04-18T01:02:10Z

Could you add a doc comments clarifying what this does for escaping?

Since this requires FCP:
@rustbot label +I-libs-api-nominated

library/alloc/src/ffi/c_str.rs

tamird

Could you add a doc comments clarifying what this does for escaping?

Done.

library/alloc/src/ffi/c_str.rs

{B,C}Str: minor cleanup (hopefully) uncontroversial bits extracted from rust-lang#139994.

Rollup merge of rust-lang#140118 - tamird:cstr-cleanup, r=joboet {B,C}Str: minor cleanup (hopefully) uncontroversial bits extracted from rust-lang#139994.

bors · 2025-04-21T23:46:49Z

☔ The latest upstream changes (presumably #140127) made this pull request unmergeable. Please resolve the merge conflicts.

{B,C}Str: minor cleanup (hopefully) uncontroversial bits extracted from rust-lang#139994.

Amanieu · 2025-04-29T15:51:53Z

In rust-lang/libs-team#550 the @rust-lang/libs-api team decided against implementing Display for CStr in favor of adding a display method like on OsStr and Path.

tamird · 2025-04-29T15:55:08Z

Shall I rework this? Can I use impl fmt::Display in the implementation, or does it need to be a nameable type?

Amanieu · 2025-05-03T11:08:52Z

Yes, it's fine to rework this to return impl fmt::Display. Also a tracking issue should be created for this.

tamird · 2025-05-24T11:18:58Z

@Amanieu updated the implementation and reopened #139984 as the tracking issue.

The implementation delegates to `<ByteStr as Display>::fmt`. Link: rust-lang/libs-team#550 Link: rust-lang#139984.

Amanieu · 2025-05-28T16:34:58Z

@bors r+

bors · 2025-05-28T16:35:01Z

📌 Commit 947be5f has been approved by Amanieu

It is now in the queue for this repository.

add `CStr::display` The implementation delegates to `<ByteStr as Display>::fmt`. Link: rust-lang/libs-team#550 Link: rust-lang#139984. r? `@BurntSushi` cc `@Darksonn` `@tgross35` `@ojeda` `@joshtriplett`

Rollup of 7 pull requests Successful merges: - #125087 (Optimize `Seek::stream_len` impl for `File`) - #133823 (Use `cfg_attr_trace` in AST with a placeholder attribute for accurate suggestion) - #138285 (Stabilize `repr128`) - #139994 (add `CStr::display`) - #141477 (Path::with_extension: show that it adds an extension where one did no…) - #141533 (clean up old rintf leftovers) - #141693 (Subtree update of `rust-analyzer`) r? `@ghost` `@rustbot` modify labels: rollup

add `CStr::display` The implementation delegates to `<ByteStr as Display>::fmt`. Link: rust-lang/libs-team#550 Link: rust-lang#139984. r? ``@BurntSushi`` cc ``@Darksonn`` ``@tgross35`` ``@ojeda`` ``@joshtriplett``

Rollup of 8 pull requests Successful merges: - #125087 (Optimize `Seek::stream_len` impl for `File`) - #138285 (Stabilize `repr128`) - #139994 (add `CStr::display`) - #141477 (Path::with_extension: show that it adds an extension where one did no…) - #141533 (clean up old rintf leftovers) - #141690 (Add `rustc_diagnostic_item` to `sys::Mutex` methods) - #141693 (Subtree update of `rust-analyzer`) - #141702 (Add eholk to compiler reviewer rotation) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 4 pull requests Successful merges: - #138285 (Stabilize `repr128`) - #139994 (add `CStr::display`) - #141571 (coretests: extend and simplify float tests) - #141656 (CI: Add cargo tests to aarch64-apple-darwin) Failed merges: - #141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`) - #141636 (avoid some usages of `&mut P<T>` in AST visitors) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #139994 - tamird:cstr-display, r=Amanieu add `CStr::display` The implementation delegates to `<ByteStr as Display>::fmt`. Link: rust-lang/libs-team#550 Link: #139984. r? ```@BurntSushi``` cc ```@Darksonn``` ```@tgross35``` ```@ojeda``` ```@joshtriplett```

add `CStr::display` The implementation delegates to `<ByteStr as Display>::fmt`. Link: rust-lang/libs-team#550 Link: rust-lang#139984. r? ```@BurntSushi``` cc ```@Darksonn``` ```@tgross35``` ```@ojeda``` ```@joshtriplett```

Rollup of 4 pull requests Successful merges: - rust-lang#138285 (Stabilize `repr128`) - rust-lang#139994 (add `CStr::display`) - rust-lang#141571 (coretests: extend and simplify float tests) - rust-lang#141656 (CI: Add cargo tests to aarch64-apple-darwin) Failed merges: - rust-lang#141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`) - rust-lang#141636 (avoid some usages of `&mut P<T>` in AST visitors) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 4 pull requests Successful merges: - rust-lang/rust#138285 (Stabilize `repr128`) - rust-lang/rust#139994 (add `CStr::display`) - rust-lang/rust#141571 (coretests: extend and simplify float tests) - rust-lang/rust#141656 (CI: Add cargo tests to aarch64-apple-darwin) Failed merges: - rust-lang/rust#141430 (remove `visit_clobber` and move `DummyAstNode` to `rustc_expand`) - rust-lang/rust#141636 (avoid some usages of `&mut P<T>` in AST visitors) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned BurntSushi Apr 17, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2025

ojeda mentioned this pull request Apr 18, 2025

core wanted features & bugfixes Rust-for-Linux/linux#514

Open

16 tasks

rustbot added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 18, 2025

tgross35 added needs-fcp This change is insta-stable, or significant enough to need a team FCP to proceed. and removed I-libs-api-nominated Nominated for discussion during a libs-api team meeting. labels Apr 18, 2025

bjorn3 reviewed Apr 18, 2025

View reviewed changes

library/alloc/src/ffi/c_str.rs Outdated Show resolved Hide resolved

tamird force-pushed the cstr-display branch from 2eb798b to a0bf57b Compare April 18, 2025 15:36

tamird commented Apr 18, 2025

View reviewed changes

library/alloc/src/ffi/c_str.rs Outdated Show resolved Hide resolved

tamird force-pushed the cstr-display branch from a0bf57b to 8900926 Compare April 18, 2025 19:15

This was referenced Apr 19, 2025

Tracking Issue for CStr::display #139984

Open

{B,C}Str: minor cleanup #140118

Merged

ChrisDenton added a commit to ChrisDenton/rust that referenced this pull request Apr 21, 2025

Rollup merge of rust-lang#140118 - tamird:cstr-cleanup, r=joboet

1cb9a0d

{B,C}Str: minor cleanup (hopefully) uncontroversial bits extracted from rust-lang#139994.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 21, 2025

Unrolled build for rust-lang#140118

a62394a

Rollup merge of rust-lang#140118 - tamird:cstr-cleanup, r=joboet {B,C}Str: minor cleanup (hopefully) uncontroversial bits extracted from rust-lang#139994.

tgross35 added the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 21, 2025

tamird force-pushed the cstr-display branch from 8900926 to f7359d5 Compare April 22, 2025 01:00

github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Apr 23, 2025

Rollup merge of rust-lang#140118 - tamird:cstr-cleanup, r=joboet

9be04dc

{B,C}Str: minor cleanup (hopefully) uncontroversial bits extracted from rust-lang#139994.

Amanieu removed the I-libs-api-nominated Nominated for discussion during a libs-api team meeting. label Apr 29, 2025

tamird changed the title ~~impl Display for CStr{,ing}~~ add CStr::display May 24, 2025

tamird force-pushed the cstr-display branch from f7359d5 to c9d2ecb Compare May 24, 2025 11:18

This comment has been minimized.

Sign in to view

tamird force-pushed the cstr-display branch from c9d2ecb to 8f11582 Compare May 24, 2025 11:53

This comment has been minimized.

Sign in to view

add CStr::display

947be5f

The implementation delegates to `<ByteStr as Display>::fmt`. Link: rust-lang/libs-team#550 Link: rust-lang#139984.

tamird force-pushed the cstr-display branch from 8f11582 to 947be5f Compare May 24, 2025 12:25

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2025

tgross35 mentioned this pull request May 28, 2025

Rollup of 7 pull requests #141707

Closed

tgross35 mentioned this pull request May 28, 2025

Rollup of 8 pull requests #141710

Closed

jhpratt mentioned this pull request May 29, 2025

Rollup of 4 pull requests #141717

Merged

bors merged commit ba042d7 into rust-lang:master May 29, 2025
6 checks passed

rustbot added this to the 1.89.0 milestone May 29, 2025

tamird deleted the cstr-display branch May 29, 2025 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add `CStr::display` #139994

add `CStr::display` #139994

Uh oh!

tamird commented Apr 17, 2025 •

edited

Loading

Uh oh!

tgross35 commented Apr 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

tamird left a comment

Uh oh!

Uh oh!

bors commented Apr 21, 2025

Uh oh!

Amanieu commented Apr 29, 2025

Uh oh!

tamird commented Apr 29, 2025

Uh oh!

Amanieu commented May 3, 2025

Uh oh!

tamird commented May 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Amanieu commented May 28, 2025

Uh oh!

bors commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

add CStr::display #139994

add CStr::display #139994

Uh oh!

Conversation

tamird commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Apr 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tamird left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bors commented Apr 21, 2025

Uh oh!

Amanieu commented Apr 29, 2025

Uh oh!

tamird commented Apr 29, 2025

Uh oh!

Amanieu commented May 3, 2025

Uh oh!

tamird commented May 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

Amanieu commented May 28, 2025

Uh oh!

bors commented May 28, 2025

Uh oh!

Uh oh!

Uh oh!

add `CStr::display` #139994

add `CStr::display` #139994

tamird commented Apr 17, 2025 •

edited

Loading

tgross35 commented Apr 18, 2025 •

edited

Loading